why doesnt this binary converter work?

[limited_skillz]

code:

var userNumber, base : int put "Enter number: " .. get userNumber var tempWord : string := "" base := 2 loop     tempWord := tempWord + intstr (userNumber mod base)     userNumber div= base     exit when userNumber = 1 end loop put "Number in Binary: ".. for decreasing i : length (tempWord) .. 1     put tempWord (i) .. end for

with all this conversion talk i wanted to try it out for myself

why doesnt this program give the right answer? is it because of integer overflow or something?

[Tony]

you don't divide userNumber by base in the loop, you subtract userNumber mod base from it

[limited_skillz]

code:

var userNumber, base : int put "Enter number: " .. get userNumber var tempWord : string := "" base := 2 loop     tempWord := tempWord + intstr (userNumber mod base)     userNumber -= userNumber mod base     exit when userNumber = 1     put tempWord     delay (10) end loop put "Number in Binary: ".. for decreasing i : length (tempWord) .. 1     put tempWord (i) .. end for

still doesnt work, in fact it just goes on forever like this til an error occurs

[Tony]

umm... yeah... maybe I should try to actually read all of the code instead of looking at random lines

anyways,

code:

var num, base:int put "enter number:".. get num base := 2 put "" put intstr(num,0,base)

[EDEN-E]

you first code was right except one line.


When program divide 1 by 2 (which will be the last process),

the userNumber will be 0.5

However, because userNumber variable is int type, userNumber will be 0.

so loop have to be exit when userNumber = 0

[Flashkicks]

There is a Very handy MegaConverter just at the top of the Turing Help room. You should reallycheck it out. It is extremely short and efficent and does ALL the convertersions.. [fyi: it uses instr and wutnot- it is the short method... the kind the teachers dont really like ]