Health Bars for my RPG

[Zeppelin]

Ok I'm making an RPG for my ISP but I'm having trouble with the health bars.

code:

var HealthBar1 : int := Pic.FileNew ("Health Bar 1 copy.jpg") var HealthBar2 : int := Pic.FileNew ("Health Bar 2 copy.jpg") var HealthBar3 : int := Pic.FileNew ("Health Bar 3 copy.jpg") var HealthBar4 : int := Pic.FileNew ("Health Bar 4 copy.jpg") var HealthBar5 : int := Pic.FileNew ("Health Bar 5 copy.jpg") var HealthBar6 : int := Pic.FileNew ("Health Bar 6 copy.jpg") var HealthBar7 : int := Pic.FileNew ("Health Bar 7 copy.jpg") var HealthBar8 : int := Pic.FileNew ("Health Bar 8 copy.jpg") var HealthBar9 : int := Pic.FileNew ("Health Bar 9 copy.jpg") var HealthBar10 : int := Pic.FileNew ("Health Bar 10 copy.jpg") var HealthBar11 : int := Pic.FileNew ("Health Bar 11 copy.jpg") var HealthBar12 : int := Pic.FileNew ("Health Bar 12 copy.jpg") var HealthBar13 : int := Pic.FileNew ("Health Bar 13 copy.jpg") var HealthBar14 : int := Pic.FileNew ("Health Bar 14 copy.jpg") var HealthBar15 : int := Pic.FileNew ("Health Bar 15 copy.jpg") var HealthBar16 : int := Pic.FileNew ("Health Bar 16 copy.jpg") var HealthBar17 : int := Pic.FileNew ("Health Bar 17 copy.jpg") var HealthBar18 : int := Pic.FileNew ("Health Bar 18 copy.jpg") var HealthBar19 : int := Pic.FileNew ("Health Bar 19 copy.jpg") var HealthBar20 : int := Pic.FileNew ("Health Bar 20 copy.jpg") var HealthBar21 : int := Pic.FileNew ("Health Bar 21 copy.jpg") var HealthBar22 : int := Pic.FileNew ("Health Bar 22 copy.jpg") var HealthBar23 : int := Pic.FileNew ("Health Bar 23 copy.jpg") var HealthBar24 : int := Pic.FileNew ("Health Bar 24 copy.jpg") var HealthBar25 : int := Pic.FileNew ("Health Bar 25 copy.jpg") var HealthBar26 : int := Pic.FileNew ("Health Bar 26 copy.jpg") var HealthBar27 : int := Pic.FileNew ("Health Bar 27 copy.jpg") var HealthBar28 : int := Pic.FileNew ("Health Bar 28 copy.jpg") var HealthBar29 : int := Pic.FileNew ("Health Bar 29 copy.jpg") var HealthBar30 : int := Pic.FileNew ("Health Bar 30 copy.jpg") var HealthBar31 : int := Pic.FileNew ("Health Bar 31 copy.jpg") var HealthBar32 : int := Pic.FileNew ("Health Bar 32 copy.jpg") var HealthBar33 : int := Pic.FileNew ("Health Bar 33 copy.jpg") var HealthBar34 : int := Pic.FileNew ("Health Bar 34 copy.jpg") var HealthBar35 : int := Pic.FileNew ("Health Bar 35 copy.jpg") var HealthBar36 : int := Pic.FileNew ("Health Bar 36 copy.jpg") var HealthBar37 : int := Pic.FileNew ("Health Bar 37 copy.jpg") var HealthBar38 : int := Pic.FileNew ("Health Bar 38 copy.jpg") var HealthBar39 : int := Pic.FileNew ("Health Bar 39 copy.jpg") var HealthBar40 : int := Pic.FileNew ("Health Bar 40 copy.jpg") var HealthBar41 : int := Pic.FileNew ("Health Bar 41 copy.jpg") var HealthBar42 : int := Pic.FileNew ("Health Bar 42 copy.jpg") var HealthBar43 : int := Pic.FileNew ("Health Bar 43 copy.jpg") var HealthBar44 : int := Pic.FileNew ("Health Bar 44 copy.jpg") var HealthBar45 : int := Pic.FileNew ("Health Bar 45 copy.jpg") var HealthBar46 : int := Pic.FileNew ("Health Bar 46 copy.jpg") var HealthBar47 : int := Pic.FileNew ("Health Bar 47 copy.jpg") var HealthBar48 : int := Pic.FileNew ("Health Bar 48 copy.jpg") var HealthBar49 : int := Pic.FileNew ("Health Bar 49 copy.jpg") var HealthBar50 : int := Pic.FileNew ("Health Bar 50 copy.jpg") procedure HealthyBar1     if Health1 div MaxHealth1 > 0 and Health1 div MaxHealth1 <= 0.02 then         Pic.Draw (HealthBar1, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.02 and Health1 div MaxHealth1 <= 0.04 then         Pic.Draw (HealthBar2, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.04 and Health1 div MaxHealth1 <= 0.06 then         Pic.Draw (HealthBar3, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.06 and Health1 div MaxHealth1 <= 0.08 then         Pic.Draw (HealthBar4, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.08 and Health1 div MaxHealth1 <= 0.1 then         Pic.Draw (HealthBar5, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.1 and Health1 div MaxHealth1 <= 0.12 then         Pic.Draw (HealthBar6, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.12 and Health1 div MaxHealth1 <= 0.14 then         Pic.Draw (HealthBar7, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.14 and Health1 div MaxHealth1 <= 0.16 then         Pic.Draw (HealthBar8, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.16 and Health1 div MaxHealth1 <= 0.18 then         Pic.Draw (HealthBar9, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.18 and Health1 div MaxHealth1 <= 0.2 then         Pic.Draw (HealthBar10, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.20 and Health1 div MaxHealth1 <= 0.22 then         Pic.Draw (HealthBar11, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.22 and Health1 div MaxHealth1 <= 0.24 then         Pic.Draw (HealthBar12, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.24 and Health1 div MaxHealth1 <= 0.26 then         Pic.Draw (HealthBar13, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.26 and Health1 div MaxHealth1 <= 0.28 then         Pic.Draw (HealthBar14, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.28 and Health1 div MaxHealth1 <= 0.3 then         Pic.Draw (HealthBar15, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.30 and Health1 div MaxHealth1 <= 0.32 then         Pic.Draw (HealthBar16, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.32 and Health1 div MaxHealth1 <= 0.34 then         Pic.Draw (HealthBar17, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.34 and Health1 div MaxHealth1 <= 0.36 then         Pic.Draw (HealthBar18, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.36 and Health1 div MaxHealth1 <= 0.38 then         Pic.Draw (HealthBar19, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.38 and Health1 div MaxHealth1 <= 0.40 then         Pic.Draw (HealthBar20, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.40 and Health1 div MaxHealth1 <= 0.42 then         Pic.Draw (HealthBar21, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.42 and Health1 div MaxHealth1 <= 0.44 then         Pic.Draw (HealthBar22, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.44 and Health1 div MaxHealth1 <= 0.46 then         Pic.Draw (HealthBar23, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.46 and Health1 div MaxHealth1 <= 0.48 then         Pic.Draw (HealthBar24, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.48 and Health1 div MaxHealth1 <= 0.5 then         Pic.Draw (HealthBar25, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.50 and Health1 div MaxHealth1 <= 0.52 then         Pic.Draw (HealthBar26, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.52 and Health1 div MaxHealth1 <= 0.54 then         Pic.Draw (HealthBar27, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.54 and Health1 div MaxHealth1 <= 0.56 then         Pic.Draw (HealthBar28, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.56 and Health1 div MaxHealth1 <= 0.58 then         Pic.Draw (HealthBar29, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.58 and Health1 div MaxHealth1 <= 0.60 then         Pic.Draw (HealthBar30, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.60 and Health1 div MaxHealth1 <= 0.62 then         Pic.Draw (HealthBar31, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.62 and Health1 div MaxHealth1 <= 0.64 then         Pic.Draw (HealthBar32, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.64 and Health1 div MaxHealth1 <= 0.66 then         Pic.Draw (HealthBar33, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.66 and Health1 div MaxHealth1 <= 0.68 then         Pic.Draw (HealthBar34, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.68 and Health1 div MaxHealth1 <= 0.70 then         Pic.Draw (HealthBar35, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.70 and Health1 div MaxHealth1 <= 0.72 then         Pic.Draw (HealthBar36, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.72 and Health1 div MaxHealth1 <= 0.74 then         Pic.Draw (HealthBar37, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.74 and Health1 div MaxHealth1 <= 0.76 then         Pic.Draw (HealthBar38, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.76 and Health1 div MaxHealth1 <= 0.78 then         Pic.Draw (HealthBar39, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.78 and Health1 div MaxHealth1 <= 0.80 then         Pic.Draw (HealthBar40, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.80 and Health1 div MaxHealth1 <= 0.82 then         Pic.Draw (HealthBar41, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.82 and Health1 div MaxHealth1 <= 0.84 then         Pic.Draw (HealthBar42, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.84 and Health1 div MaxHealth1 <= 0.86 then         Pic.Draw (HealthBar43, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.86 and Health1 div MaxHealth1 <= 0.88 then         Pic.Draw (HealthBar44, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.88 and Health1 div MaxHealth1 <= 0.90 then         Pic.Draw (HealthBar45, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.90 and Health1 div MaxHealth1 <= 0.92 then         Pic.Draw (HealthBar46, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.92 and Health1 div MaxHealth1 <= 0.94 then         Pic.Draw (HealthBar47, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.94 and Health1 div MaxHealth1 <= 0.96 then         Pic.Draw (HealthBar48, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.96 and Health1 div MaxHealth1 <= 0.98 then         Pic.Draw (HealthBar49, 100, 100, picMerge)     elsif Health1 div MaxHealth1 > 0.98 and Health1 div MaxHealth1 <= 1 then         Pic.Draw (HealthBar50, 100, 100, picMerge)     end if end HealthyBar1 procedure HealthyBar2     if Health2 div MaxHealth2 > 0 and Health2 div MaxHealth2 <= 0.02 then         Pic.Draw (HealthBar1, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.02 and Health2 div MaxHealth2 <= 0.04 then         Pic.Draw (HealthBar2, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.04 and Health2 div MaxHealth2 <= 0.06 then         Pic.Draw (HealthBar3, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.06 and Health2 div MaxHealth2 <= 0.08 then         Pic.Draw (HealthBar4, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.08 and Health2 div MaxHealth2 <= 0.1 then         Pic.Draw (HealthBar5, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.1 and Health2 div MaxHealth2 <= 0.12 then         Pic.Draw (HealthBar6, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.12 and Health2 div MaxHealth2 <= 0.14 then         Pic.Draw (HealthBar7, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.14 and Health2 div MaxHealth2 <= 0.16 then         Pic.Draw (HealthBar8, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.16 and Health2 div MaxHealth2 <= 0.18 then         Pic.Draw (HealthBar9, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.18 and Health2 div MaxHealth2 <= 0.2 then         Pic.Draw (HealthBar10, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.20 and Health2 div MaxHealth2 <= 0.22 then         Pic.Draw (HealthBar11, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.22 and Health2 div MaxHealth2 <= 0.24 then         Pic.Draw (HealthBar12, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.24 and Health2 div MaxHealth2 <= 0.26 then         Pic.Draw (HealthBar13, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.26 and Health2 div MaxHealth2 <= 0.28 then         Pic.Draw (HealthBar14, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.28 and Health2 div MaxHealth2 <= 0.3 then         Pic.Draw (HealthBar15, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.30 and Health2 div MaxHealth2 <= 0.32 then         Pic.Draw (HealthBar16, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.32 and Health2 div MaxHealth2 <= 0.34 then         Pic.Draw (HealthBar17, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.34 and Health2 div MaxHealth2 <= 0.36 then         Pic.Draw (HealthBar18, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.36 and Health2 div MaxHealth2 <= 0.38 then         Pic.Draw (HealthBar19, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.38 and Health2 div MaxHealth2 <= 0.40 then         Pic.Draw (HealthBar20, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.40 and Health2 div MaxHealth2 <= 0.42 then         Pic.Draw (HealthBar21, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.42 and Health2 div MaxHealth2 <= 0.44 then         Pic.Draw (HealthBar22, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.44 and Health2 div MaxHealth2 <= 0.46 then         Pic.Draw (HealthBar23, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.46 and Health2 div MaxHealth2 <= 0.48 then         Pic.Draw (HealthBar24, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.48 and Health2 div MaxHealth2 <= 0.5 then         Pic.Draw (HealthBar25, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.50 and Health2 div MaxHealth2 <= 0.52 then         Pic.Draw (HealthBar26, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.52 and Health2 div MaxHealth2 <= 0.54 then         Pic.Draw (HealthBar27, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.54 and Health2 div MaxHealth2 <= 0.56 then         Pic.Draw (HealthBar28, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.56 and Health2 div MaxHealth2 <= 0.58 then         Pic.Draw (HealthBar29, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.58 and Health2 div MaxHealth2 <= 0.60 then         Pic.Draw (HealthBar30, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.60 and Health2 div MaxHealth2 <= 0.62 then         Pic.Draw (HealthBar31, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.62 and Health2 div MaxHealth2 <= 0.64 then         Pic.Draw (HealthBar32, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.64 and Health2 div MaxHealth2 <= 0.66 then         Pic.Draw (HealthBar33, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.66 and Health2 div MaxHealth2 <= 0.68 then         Pic.Draw (HealthBar34, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.68 and Health2 div MaxHealth2 <= 0.70 then         Pic.Draw (HealthBar35, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.70 and Health2 div MaxHealth2 <= 0.72 then         Pic.Draw (HealthBar36, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.72 and Health2 div MaxHealth2 <= 0.74 then         Pic.Draw (HealthBar37, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.74 and Health2 div MaxHealth2 <= 0.76 then         Pic.Draw (HealthBar38, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.76 and Health2 div MaxHealth2 <= 0.78 then         Pic.Draw (HealthBar39, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.78 and Health2 div MaxHealth2 <= 0.80 then         Pic.Draw (HealthBar40, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.80 and Health2 div MaxHealth2 <= 0.82 then         Pic.Draw (HealthBar41, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.82 and Health2 div MaxHealth2 <= 0.84 then         Pic.Draw (HealthBar42, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.84 and Health2 div MaxHealth2 <= 0.86 then         Pic.Draw (HealthBar43, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.86 and Health2 div MaxHealth2 <= 0.88 then         Pic.Draw (HealthBar44, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.88 and Health2 div MaxHealth2 <= 0.90 then         Pic.Draw (HealthBar45, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.90 and Health2 div MaxHealth2 <= 0.92 then         Pic.Draw (HealthBar46, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.92 and Health2 div MaxHealth2 <= 0.94 then         Pic.Draw (HealthBar47, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.94 and Health2 div MaxHealth2 <= 0.96 then         Pic.Draw (HealthBar48, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.96 and Health2 div MaxHealth2 <= 0.98 then         Pic.Draw (HealthBar49, 300, 100, picMerge)     elsif Health2 div MaxHealth2 > 0.98 and Health2 div MaxHealth2 <= 1 then         Pic.Draw (HealthBar50, 300, 100, picMerge)     end if end HealthyBar2

The first health bar shows up on the screen but as soon as the character takes damage it disappears.

All the variables for health (Health1, MaxHealth1, etc.) are integers.

[Saad]

Your error is that div does an integer division (Remainder is removed), ie 3 div 2 = 1
What you want to do is use the / operator, 3 / 2 = 1.5

Also That is a lot it redundant code. I really suggest using another method to draw the health bars, since you can calculate percent of health the player has, multiply the percent health by how long it should be if the player has full health

[Tony]

Indeed, you should just draw the health bar with Draw.Box or something. You could still load a single image for style around the bar itself.

If you absolutely must have a bunch of pictures, remember how series of related variables should be an array

Turing:

var healthBar : array 1 .. 50 of int for i: 1 .. 50    healthBar[i] := Pic.FileNew("Health Bar " + intstr(i) + " copy.jpg") end for

And then all of the if .. draw .. elseif .. draw 's could be collapsed into a single line.

[Clayton]

Turing:

View.Set ("offscreenonly") const BAR_WIDTH : int := 100 const BAR_HEIGHT : int := 30 const MAX_HEALTH : int := 500 var current_health : int := MAX_HEALTH loop     Draw.Box (maxx div 2 - (BAR_WIDTH div 2), maxy div 2 - (BAR_HEIGHT div 2), maxx div 2 + (BAR_WIDTH div 2), maxy div 2 + (BAR_HEIGHT div 2), black)     Draw.FillBox (maxx div 2 - (BAR_WIDTH div 2) + 1, maxy div 2 - (BAR_HEIGHT div 2) + 1, maxx div 2 + round ((current_health / MAX_HEALTH) * 100) - (BAR_WIDTH div 2) - 1, maxy div 2 + (BAR_HEIGHT         div 2) -         1, black)     put "Health: ", round ((current_health / MAX_HEALTH) * 100), "%"     current_health -= 1     Time.Delay (10)     View.Update     Draw.Cls     exit when current_health = 0 end loop