Understanding fstream

[FeZbOy]

I am currently in an introduction to C++ course in college. Currently, they are having us use fstream to read from and write to files. (simple .txt files, nothing major)

My current problem is this. The program reads from a file of names, pay rates, and hours worked. I have a while loop detecting when the stream fails. When it does, the program finishes. However, the last records are duplicated, as if the stream re-reads the last line. Is there a way to prevent this from happening?

Thanks for helping.

[apython1992]

Can you paste your fstream code?

[unoho]

i usually do this:

code:

ifstream fileName("file.txt"); string input if(!fileName){ cerr<<"Error opening the file"; return 0; } while(fileName>>input){ //do ur code here }

that usually prevents any duplication for last line.

[FeZbOy]

Here is the code.

code:

string firstName;     string lastName;     double hoursWorked;     double ratePay;     double grossPay;         bool cont = true;         ifstream inData;     ofstream outData;         inData.open("hours.txt");     if (inData.fail())     {         cout << "File not found. Please try again";     }     else     {         while(cont)         {             if (inData.fail())             {                 inData.clear();                 cout << "DONE";                 cont = false;                 inData.close();             }             else             {                 inData >> firstName;                 inData >> lastName;                 inData >> hoursWorked;                 inData >> ratePay;                                 cout << firstName << " " << lastName << endl;                 grossPay = hoursWorked * ratePay;                 cout << grossPay <<endl;             }         }     }

Also, the hours.txt file

code:

John Smith 25.0 15.00 Mary Jones 33.5 17.50 Pat Brown 40.0 21.00 Jen Simpson 37.5 18.00 Gary Phillips 15.0 11.25

The Gary Phillips line is the duplicated one.

[apython1992]

According to official C++ documentation:

Quote:

The function returns true if either the failbit or the badbit is set. At least one of these flags is set when some error other than reaching the End-Of-File occurs during an input operation.

In other words, ios::fail() will not raise any flag at the end of file. I believe what you want is something more like while(file.good()): http://www.cplusplus.com/reference/iostream/ios/good/

[FeZbOy]

I found the problem. The supplied file had an extra line before the EOF. Clearing that solved the problem.

Thanks everyone for all your help!