Programming C, C++, Java, PHP, Ruby, Turing, VB
Computer Science Canada 
Programming C, C++, Java, PHP, Ruby, Turing, VB  

Username:   Password: 
 RegisterRegister   
 Hey im a noob programmer and have created a relatively addicting game. Suggestions welcomed greatly.
Index -> Programming, Turing -> Turing Submissions
View previous topic Printable versionDownload TopicRate TopicSubscribe to this topicPrivate MessagesRefresh page View next topic
Author Message
chimerix




PostPosted: Tue Dec 01, 2009 4:57 pm   Post subject: Hey im a noob programmer and have created a relatively addicting game. Suggestions welcomed greatly.

So the code and pic files are in the attachments (or should be). And i do realize you will all say it is a piece of crap and hurts your eyes, but hey i started turing 1 week ago and enjoy reading criticism.


deftank.bmp
 Description:
 Filesize:  1.59 KB
 Viewed:  2953 Time(s)

deftank.bmp



attktankblank.bmp
 Description:
 Filesize:  1.69 KB
 Viewed:  2955 Time(s)

attktankblank.bmp



attktank.bmp
 Description:
 Filesize:  1.52 KB
 Viewed:  2953 Time(s)

attktank.bmp



Background.bmp
 Description:
 Filesize:  138.16 KB
 Viewed:  120 Time(s)

Background.bmp



11-12 final copy.t
 Description:

Download
 Filename:  11-12 final copy.t
 Filesize:  8.69 KB
 Downloaded:  194 Time(s)

Sponsor
Sponsor
Sponsor
sponsor
rdrake




PostPosted: Tue Dec 01, 2009 5:43 pm   Post subject: RE:Hey im a noob programmer and have created a relatively addicting game. Suggestions welcomed greatly.

A suggestion for next time; zip all your files up so you only have to post one attachment.
Tony




PostPosted: Tue Dec 01, 2009 8:43 pm   Post subject: RE:Hey im a noob programmer and have created a relatively addicting game. Suggestions welcomed greatly.

code:

put "What difficulty would you like to play? Easy, Medium, Hard or Insane? " ..
        get difficulty

        if difficulty = "Easy" then
...

Making a user spell out a difficulty setting (in full, matching capitalization) is a pretty bad UI. It's not intuitive, and prone to errors. Worse yet, it's not consistent with the use of import GUI elsewhere, which brings me to:
code:

loop

        Font.Draw ("Turing Tank Defence", 230, 320, titleFont, black)
...
var playBox : int := GUI.CreateButtonFull (300, 10, 0, "Let's Rock!", GUI.Quit, 0, 'D', true)

        exit when GUI.ProcessEvent
    end loop

I'm not sure how well it works to create a new button 30 times each second (or whatever). Just about always, you want to have variable declarations outside of a loop. Also, there is no need to redraw all that text either.

Once again, it's not consistent that your instructions are in Font.Draw, but the title is in ASCII put statements.

I don't understand the need for "a"
code:

a := -1
defx := defx + a

how about just
code:

defx := defx - 1

or some prefer
code:

defx -= 1

Boolean variables!
code:

if bullet = true then

bullet is already boolean, so it would suffice to say
code:

if bullet then

Though perhaps with a more descriptive name.
Perhaps end end-of-game
code:

if life = 0 then
...

should be made into the procedure of its own as well, just to clear up the main loop. You had the right idea with factoring elements into procedures.

Actually, you are checking for that condition twice.
code:

if life = 0
...
exit when life = 0
Latest from compsci.ca/blog: Tony's programming blog. DWITE - a programming contest.
gan gar




PostPosted: Sun Dec 13, 2009 1:14 am   Post subject: RE:Hey im a noob programmer and have created a relatively addicting game. Suggestions welcomed greatly.

pretty good.
mirhagk




PostPosted: Sun Dec 13, 2009 9:46 am   Post subject: RE:Hey im a noob programmer and have created a relatively addicting game. Suggestions welcomed greatly.

not bad, but like tony said could be improved. First off with what tony said the user shouldn't have to spell out "Easy" or w/e exactly as typed. you should check for all cases. And turing has a command for that
Turing:

difficulty:=Str.Lower(difficulty)

now just check for the lower case spellings of those words.

Secondly, what is the point of having the background be a picture if it's all just going to be one colour, couldn't you just simply draw a red box instead (also do the same with the "attktankblank")

Turing has a hard time with pictures, and it would be much more effecient to just draw it yourself
Turing_Gamer




PostPosted: Mon Dec 14, 2009 11:56 am   Post subject: Re: Hey im a noob programmer and have created a relatively addicting game. Suggestions welcomed greatly.

Why not use picMerge for your pictures?
It will make it neater and you can change the background without effecting you pictures.
Display posts from previous:   
   Index -> Programming, Turing -> Turing Submissions
View previous topic Tell A FriendPrintable versionDownload TopicRate TopicSubscribe to this topicPrivate MessagesRefresh page View next topic

Page 1 of 1  [ 6 Posts ]
Jump to:   


Style:  
Search: