My take on Mario

[DifinityRJ]

Hi, im in grade 10 and for my ISU i making a Mario game. This is my first year in programming, and Turing is my first language. Yes, it isn't exactly like Mario, i know. Also it isn't completely done, but i would like some constructive comments on how the game feels, and its fun factor for you. You move with arrow keys and jump with Space.

Note: This isn't a sidescroller, its basically rooms.

[CodeMonkey2000]

Thats pretty good. There are some problems with collisons though. Cant wait to see more updates.

[DifinityRJ]

im using Math.Distance for my collision, is there any better way to do it?

[CodeMonkey2000]

Well I used my own collision function on my mario game(it's an updated verson of my program here) that checks if two images are colliding. The same function is used for level and enemy collision.

[DifinityRJ]

I havent learnt record or functions or .floor, i dont even know what that is. Pretty much the code doesn't make any sense to me.

[Clayton]

then take a look through the Turing Walkthrough at all of the great tutorials a quick runthrough:

Records:

records are collections of data, meaning you can make them hold anything you want, ie:

Turing:

var foo :     record :         x, y :int         name : string     end record foo.x := 5 foo.y := 10 foo.name := "bob"

Functions:

Functions are methods that compute new values from arguments passed to it, and return that value, ie:

Turing:

function foo (num, num2 : int) : int     return num + num2 end foo put foo (5, 5)

[CodeMonkey2000]

you can look at the turing tutorials for info on functions,records and Mario.floor is just a variable (it shows up as a predefied function at school for some reason). I dont get how you are using Math.Distance though. I would just use x,y comparison.

[Clayton]

sorry, my function code should have been as follows:

Turing:

function foo (num, num2 : int) : int     result num + num2 end foo put foo (5, 5)

sorry for the confusion

[DifinityRJ]

Here is if Mario hits goomba, gy1 being goomba's y position and gx1 being his x position, and "x" being mario's x position, and "y" being Mario's y position.

code:

if y - 5 > gy1 and Math.Distance (x, y, gx1, gy1) <18  then             check := 1             up := true             y := y - 8             Mariograv := -0.1             goombadeath := true end if

Here is if goomba hits mario

code:

if Math.Distance (x, y, gx1, gy1) < 10 and big = false and donthit = false then             left := false             right := false             check := 0             last := 0             Pic.Draw (dead, x, y, picMerge)             Mariodead := true end if

This is probably inefficient, but i dont know of any better way.

[Clayton]

even better, change that into a function:

Turing:

function check_collision (x1, y1, x2, y2, distance : int) : boolean     result Math.Distance (x1, y1, x2, y2) < distance end check_collision

then you can simply call that function in an if statement, and if it's true, change your variable accordingly, or even better, call a procedure to do it for you.

[CodeMonkey2000]

shouldnt it be:

Turing:

function check_collision (x1, y1, x2, y2, distance : int) : boolean     if Math.Distance (x1, y1, x2, y2) < distance then            result true      else           result false      end if end check_collision

[Clayton]

mine is perfectly legal. In the if statement, an expression has to return a boolean (true or false). Seeing as my function is returning a boolean, we can do away with the if and just return the boolean that would otherwise show up in the if (this only works when there are only two options based on one condition though).

EDIT:

We can work your function down to (basically):

Turing:

function check_collision (x1, y1, x2, y2, distance : int) : boolean     if true then         result true     else         result false     end if end check_collision

This allows us to do something like I did.