I'll see if I can help.
| code: |
var winMain : int := Window.Open ("graphics :800;600")
var key, key2 : array char of boolean var y, y2, y3, y4 : int y2 := 100 y := 20 y3 := 20 y4 := 100 |
Okay, right here I would change a few things. First, you don't need four y variables for two paddles. Since the paddles don't change height, you can always set the second y coordinates for each paddle to be 80 pixels above the first. Second, you don't need two char arrays for input, one will do just fine (at least in my experience). When you get the input, it tracks all the keyboard input at once, for you to use however you like. I'll explain this in a sec.
| code: |
drawfillbox (20, y, 0, y2, 7)
delay (3) Input.KeyDown (key) drawfillbox (20, y, 0, y2, 0) |
Alright, here is where you can get rid of two of the four y variables. Since the heights of the paddles never changes, you don't need to change all the variables independently. Instead, you can just set the Draw procedure to something like this:
| code: |
Draw.FillBox(0,y,20,y+80,7) |
| code: |
drawfillbox (780, y3, 800, y4, 7)
delay (3) Input.KeyDown (key2) drawfillbox (780, y3, 800, y4, 0) |
What you've done here is doubled both the delay and the Input command. Generally, this is unnecessary. As this is a game, you want to get rid of any delays that could adversely affect the flow of the code; in this case, you're putting a delay between both Input commands, meaning that if players 1 and 2 both press their "down" key when player 2's input call comes, only player 2's paddle will move. Also, you don't need to call the input procedure twice for this kind of input. Since the command tells you all of the keyboard input at any one instant, you can tell if both player's keys are being pressed at the same time, so one will do just fine.
| code: |
if key ('S') or key ('s') then
y := y - 1 y2 := y2 - 1 end if if key ('W') or key ('w') then y := y + 1 y2 := y2 + 1 end if if key2 (KEY_UP_ARROW) then y3 := y3 + 1 y4 := y4 + 1 end if if key2 (KEY_DOWN_ARROW) then y3 := y3 - 1 y4 := y4 - 1 end if end loop View.Set |
Considering what I've said above, you can get rid of y2 and y4 in these procedures. Additionally, you could consider making a "paddle_height" integer constant to use in place of the "80" in the draw commands, so if you want to change the paddle heights, all you need to do is change one value at the start of the program instead of going to both (or more) draw procedures and changing each value by hand.
Additionally, you should reverse the order, so to speak, of the "input" and "draw" portions of your code. Essentially, something like this:
| code: |
loop
<get input> <draw things> <delay goes here> cls end loop |
This sort of organization is more orderly and efficient, especially if you're looking to add more things to your game. The way this works is as such: First, your game gets any input you might be inputting. So, it changes where the paddles are going to be draw. Then, it moves on to actually drawing the paddles in their new positions. Once that's done, it delays the code execution, to ensure the game doesn't run as fast as computerly possible, which would end with you hitting the Up arrow once and having the paddle shoot immediately off the screen. Then, after it delays, it clears the screen, leaving a clean slate for your paddles to be re-drawn in the next loop.
Hope this helps
